Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Node version specified in nvmrc to build #985

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

ekzhang
Copy link
Member

@ekzhang ekzhang commented Nov 19, 2024

We're updating from Node 18 to Node 22 LTS. Using the .nvmrc file to keep this step consistent and avoid having to change it in multiple places in the future.

This won't work until https://github.com/modal-labs/modal/pull/17482 is deployed.

We're updating from Node 18 to Node 22 LTS. Using the `.nvmrc` file to keep this step consistent and avoid having to change it in multiple places in the future.
@ekzhang ekzhang requested a review from charlesfrye November 19, 2024 22:02
@ekzhang ekzhang merged commit abc1116 into main Nov 19, 2024
5 checks passed
@ekzhang ekzhang deleted the ekzhang-patch-1 branch November 19, 2024 22:13
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-005252d.modal.run

@charlesfrye
Copy link
Collaborator

thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants