Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kedro example to use new certifi #984

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Upgrade kedro example to use new certifi #984

merged 1 commit into from
Nov 19, 2024

Conversation

pawalt
Copy link
Member

@pawalt pawalt commented Nov 19, 2024

The old certifi has a CVE:
https://nvd.nist.gov/vuln/detail/CVE-2023-37920

Type of Change

  • New example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

@pawalt pawalt requested a review from charlesfrye November 19, 2024 20:37
@pawalt
Copy link
Member Author

pawalt commented Nov 19, 2024

I ran poetry update certifi

@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-a1d01c9.modal.run

@pawalt
Copy link
Member Author

pawalt commented Nov 19, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @charlesfrye will follow-up review this.

@pawalt pawalt merged commit f3290af into main Nov 19, 2024
5 checks passed
@pawalt pawalt deleted the pawalt/certifi branch November 19, 2024 21:47
@charlesfrye
Copy link
Collaborator

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants