Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper with Dynamic Batching #841

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

cathyzbn
Copy link
Contributor

@cathyzbn cathyzbn commented Aug 9, 2024

Type of Change

  • New example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter (---)
    • Example is tested by executing with modal run or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "deploy"])
    • Example is tested by running with no arguments or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

@erikbern
Copy link
Contributor

super cool!

@cathyzbn cathyzbn requested a review from charlesfrye August 16, 2024 14:34
Copy link
Collaborator

@charlesfrye charlesfrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some changes, lmk if you want to discuss!

@charlesfrye
Copy link
Collaborator

@prbot automerge

@modal-pr-review-automation modal-pr-review-automation bot merged commit 98aede6 into main Aug 19, 2024
6 checks passed
@modal-pr-review-automation modal-pr-review-automation bot deleted the cathy/batch_whisper_Ex branch August 19, 2024 18:56
advay-modal pushed a commit that referenced this pull request Sep 20, 2024
* batched whisper initial

* fix tests + nit

* ruff

* minor adjustments

---------

Co-authored-by: Charles Frye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants