pin pytorch #570
Merged
pin pytorch #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
mwaskom
approved these changes
Feb 2, 2024
06_gpu_and_ml/vllm_inference.py
Outdated
Comment on lines
70
to
71
| "torchvision==0.16.2", | ||
| "torchaudio==2.1.2", |
There was a problem hiding this comment.
Do we need these for this example?
06_gpu_and_ml/vllm_inference.py
Outdated
| # Use the barebones hf-transfer package for maximum download speeds. No progress bar, but expect 700MB/s. | ||
| .env({"HF_HUB_ENABLE_HF_TRANSFER": "1"}) | ||
| .run_function( | ||
| download_model_to_folder, | ||
| secret=Secret.from_name("huggingface-secret"), | ||
| secrets=[Secret.from_name("huggingface-secret")], |
06_gpu_and_ml/vllm_mixtral.py
Outdated
Comment on lines
68
to
69
| "torchvision==0.16.2", | ||
| "torchaudio==2.1.2", |
|
Argh sorry about the tests failing on |
|
done: #571 should be good to rebase |
aksh-at
force-pushed
the
kning/fix-pytorch-pin
branch
from
4dc7a68 to
ba078e5
Compare
|
awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin pytorch to previous version; latest version is causing issues with the nvidia cuda image.
Type of Change
Checklist
lambda-test: falseis added to example frontmatterpython_versionfor the base image