Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining examples that are using deprecated local call syntax #556

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

chrislee973
Copy link
Contributor

@chrislee973 chrislee973 commented Jan 22, 2024

Fixes the few straggling cases in the examples that were still referencing the deprecated f(...) syntax of calling a function locally.

Type of Change

  • New Example
  • [ X] Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Closes #560

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

Copy link
Contributor

@erikbern erikbern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@erikbern
Copy link
Contributor

Something is weird with Github since it's impossible to merge this... not sure what happened

@erikbern erikbern mentioned this pull request Jan 24, 2024
@ekzhang
Copy link
Member

ekzhang commented Jan 24, 2024

I added a requirement to pass Ruff / Black in CI before merging PRs (both take <10 seconds to run) — since a couple recent changes were merged while failing CI jobs. But it looks like it's not running for external contributors.

@ekzhang
Copy link
Member

ekzhang commented Jan 24, 2024

Okay, let's try again!

@ekzhang ekzhang merged commit b4b2ad4 into modal-labs:main Jan 24, 2024
5 checks passed
@chrislee973 chrislee973 deleted the fix-local-call branch January 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants