ComfyUI example #543
Merged
ComfyUI example #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzhang
reviewed
Jan 6, 2024
Comment on lines
+134
to
+147
| from asgiproxy.config import BaseURLProxyConfigMixin, ProxyConfig | ||
| from asgiproxy.context import ProxyContext | ||
| from asgiproxy.simple_proxy import make_simple_proxy_app | ||
|
|
||
| spawn_comfyui_in_background() | ||
|
|
||
| config = type( | ||
| "Config", | ||
| (BaseURLProxyConfigMixin, ProxyConfig), | ||
| { | ||
| "upstream_base_url": f"http://{HOST}:{PORT}", | ||
| "rewrite_host_header": f"{HOST}:{PORT}", | ||
| }, | ||
| )() |
There was a problem hiding this comment.
hmm I think we should try to avoid repeating this type() magic
There was a problem hiding this comment.
Yeh I just copy-pasted this from the Streamlit example. I don't have the background on why it was setup this way.
|
When I download another model, Comfyui says null. Only the model included in the example works. Also, how do I persist the downloaded model in a modal volume? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works pretty well! I quite like UI, reminds me a lot of Grasshopper from my architecture days.
Type of Change
Checklist
lambda-test: falseis added to example frontmatter