Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to SDXL Turbo example #512

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

RohanArepally
Copy link
Contributor

@RohanArepally RohanArepally commented Dec 4, 2023

CleanShot 2023-12-04 at 13 43 28@2x

@RohanArepally RohanArepally requested a review from aksh-at December 4, 2023 18:45
Copy link
Contributor

@aksh-at aksh-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great besides minor comments!

# # Stable Diffusion XL Turbo
#
# This example is similar to the [Stable Diffusion XL](/docs/examples/stable_diffusion_xl)
# example, but it's a distilled model trained for real-time synthesis. Learn more about it [here](https://stability.ai/news/stability-ai-sdxl-turbo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also mention that this one is image-to-image, both here and in the title

"transformers~=4.35",
"accelerate~=0.25",
"safetensors~=0.4",
"transformers~=4.35", # This is needed for `import torch`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for annotating these!

num_inference_steps=4,
strength=0.9,
num_inference_steps=num_inference_steps,
strength=strength,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be useful to add something at the bottom for how to run this. I.e. what command to type

@RohanArepally RohanArepally merged commit bb2bc44 into main Dec 4, 2023
5 checks passed
@RohanArepally RohanArepally deleted the ro/mod-1942-add-example-for-sdxl-turbo branch December 4, 2023 21:23
gongy pushed a commit that referenced this pull request Jan 5, 2024
* Add comments to SDXL Turbo example

* Address PR comments

---------

Co-authored-by: Ubuntu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants