Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example simplification using @build #507

Merged
merged 9 commits into from
Jan 7, 2024
Merged

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Dec 1, 2023

Using modal-labs/modal-client#1136 for some examples.

This is just one or two lines less for most examples, but for stable_diffusion_cli it's a drastic reduction since we can use the same function for both @build() and @enter()

@erikbern erikbern force-pushed the erikbern/build-example branch 4 times, most recently from 2267a1c to e2ff559 Compare December 1, 2023 17:28
@erikbern erikbern changed the title Example simplification using __build__ Example simplification using @build Dec 20, 2023
@erikbern erikbern force-pushed the erikbern/build-example branch from 48ae570 to 32f7f49 Compare December 20, 2023 23:31
@erikbern erikbern force-pushed the erikbern/build-example branch 2 times, most recently from f444aa9 to 5db8ddc Compare December 21, 2023 14:46
@erikbern erikbern force-pushed the erikbern/build-example branch from 5db8ddc to 7013eea Compare January 7, 2024 22:57
@erikbern erikbern requested a review from thundergolfer January 7, 2024 23:08
@erikbern erikbern merged commit 650c56f into main Jan 7, 2024
5 checks passed
@erikbern erikbern deleted the erikbern/build-example branch January 7, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants