Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use background commits in flan t5 finetune #505

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Use background commits in flan t5 finetune #505

merged 2 commits into from
Jan 3, 2024

Conversation

thundergolfer
Copy link
Collaborator

@thundergolfer thundergolfer commented Dec 1, 2023 •
edited
Loading

Checkpointing without annoying callbacks:

image

Can merge this when:

  • background commits are GA
  • I remove the simulated pre-emptions (used for testing)

modal-pr-review-automation[bot]
modal-pr-review-automation bot approved these changes Dec 1, 2023
View reviewed changes
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@thundergolfer thundergolfer force-pushed the jonathon/flan-w-background-commits-dec1 branch from 4be78f0 to 2e563e9 Compare December 1, 2023 14:12
@thundergolfer thundergolfer marked this pull request as ready for review January 3, 2024 06:44
@thundergolfer thundergolfer merged commit 809446d into main Jan 3, 2024
4 of 5 checks passed
@thundergolfer thundergolfer deleted the jonathon/flan-w-background-commits-dec1 branch January 3, 2024 06:45
gongy pushed a commit that referenced this pull request Jan 5, 2024
@thundergolfer @gongy
Use background commits in flan t5 finetune (#505)
574aafe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modal-pr-review-automation modal-pr-review-automation[bot] modal-pr-review-automation[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thundergolfer