Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isort from CI #496

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Remove isort from CI #496

merged 3 commits into from
Nov 13, 2023

Conversation

ekzhang
Copy link
Member

@ekzhang ekzhang commented Nov 13, 2023

This is made redundant by Ruff.

Also updating CI to use Python 3.11, which is now standard here.

This is made redundant by Ruff.
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@erikbern
Copy link
Contributor

That reminds me, I think Ruff also replaces Black now: https://docs.astral.sh/ruff/formatter/#black-compatibility

@ekzhang
Copy link
Member Author

ekzhang commented Nov 13, 2023

Wow that's neat!

@ekzhang ekzhang merged commit 8f0afc0 into main Nov 13, 2023
5 checks passed
@ekzhang ekzhang deleted the ekzhang-patch-1 branch November 13, 2023 15:25
gongy pushed a commit that referenced this pull request Jan 5, 2024
* Remove isort from CI

This is made redundant by Ruff.

* Update check.yml

* Fix bug in mutable dataclass field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants