Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't loop forever if TGI server fails #456

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: don't loop forever if TGI server fails #456

merged 2 commits into from
Sep 28, 2023

Conversation

thundergolfer
Copy link
Collaborator

No description provided.

modal-pr-review-automation[bot]
modal-pr-review-automation bot approved these changes Sep 27, 2023
View reviewed changes
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@thundergolfer thundergolfer requested a review from gongy September 27, 2023 20:37
@thundergolfer thundergolfer merged commit 8939086 into main Sep 28, 2023
6 checks passed
@thundergolfer thundergolfer deleted the jonathon/fix-tgi-sep27 branch September 28, 2023 14:18
gongy pushed a commit that referenced this pull request Jan 5, 2024
@thundergolfer @gongy
fix: don't loop forever if TGI server fails (#456)
389eaa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modal-pr-review-automation modal-pr-review-automation[bot] modal-pr-review-automation[bot] approved these changes

@gongy gongy Awaiting requested review from gongy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thundergolfer