Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update custom node name #1044

Merged
merged 1 commit into from
Jan 13, 2025
Merged

update custom node name #1044

merged 1 commit into from
Jan 13, 2025

Conversation

kning
Copy link
Contributor

@kning kning commented Jan 13, 2025

The name of the third-party custom node changed, which broke the example; moving forward should consult this registry to find the correct name. Guessing it has to do with introducing versioning in the comfy registry

I also updated comfy-cli for good measure.

image

Type of Change

  • New example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter (---)
    • Example is tested by executing with modal run or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "deploy"])
    • Example is tested by running with no arguments or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

@kning kning requested a review from charlesfrye January 13, 2025 16:54
@charlesfrye
Copy link
Collaborator

🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-f70dcff.modal.run

@charlesfrye
Copy link
Collaborator

nice ty

@charlesfrye charlesfrye merged commit 620859f into main Jan 13, 2025
7 checks passed
@charlesfrye charlesfrye deleted the kning/fix-comfyui-example branch January 13, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants