-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-319: Add support for custom pickle type to parameterized functions #2806
Open
kramstrom
wants to merge
13
commits into
main
Choose a base branch
from
kramstrom/cli-319-add-support-for-any-type-to-parameterized-functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CLI-319: Add support for custom pickle type to parameterized functions #2806
kramstrom
wants to merge
13
commits into
main
from
kramstrom/cli-319-add-support-for-any-type-to-parameterized-functions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kramstrom
commented
Jan 24, 2025
kramstrom
commented
Jan 24, 2025
freider
reviewed
Jan 24, 2025
kramstrom
changed the title
[WIP] CLI-319: Add support for
[WIP] CLI-319: Add support for custom pickle type to parameterized functions
Jan 24, 2025
Any
type to parameterized functions
kramstrom
force-pushed
the
kramstrom/cli-319-add-support-for-any-type-to-parameterized-functions
branch
from
January 27, 2025 13:12
1663ffe
to
7c81fc8
Compare
add test typing.Annotated Rename SandboxSnapshotFromId to SandboxSnapshotGet (#2800) rename SandboxSnapshotFromId [auto-commit] [skip ci] Bump the build number Enable sandbox tests on mac (#2808) * Enable sandbox tests on mac * update scheduler placement test * remove unused import [auto-commit] [skip ci] Bump the build number
kramstrom
force-pushed
the
kramstrom/cli-319-add-support-for-any-type-to-parameterized-functions
branch
from
January 27, 2025 13:12
7c81fc8
to
b6dfc0d
Compare
…rom/cli-319-add-support-for-any-type-to-parameterized-functions
…rom/cli-319-add-support-for-any-type-to-parameterized-functions
kramstrom
changed the title
[WIP] CLI-319: Add support for custom pickle type to parameterized functions
CLI-319: Add support for custom pickle type to parameterized functions
Jan 28, 2025
…rom/cli-319-add-support-for-any-type-to-parameterized-functions
freider
reviewed
Jan 28, 2025
…rom/cli-319-add-support-for-any-type-to-parameterized-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Do not merge -- need to merge backend support before this.
modal.parameter
types other thanint
andstr
by adding a "catch-all" type that pickles whatever the user sends in.e
rized across codebaseUsage:
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog
Adds support for custom types for parameterized functions.
Usage:
For parameterized functions with web hooks you must provide a default value to any custom type parameter and these parameters cannot be overridden with web parameter inputs.