-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle resizing in pty-shell #2803
Open
azliu0
wants to merge
6
commits into
main
Choose a base branch
from
azliu/pty-shell-resize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+92
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
4 times, most recently
from
January 24, 2025 16:26
23be5fd
to
6786a06
Compare
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
from
January 24, 2025 16:27
6786a06
to
f58a46e
Compare
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
2 times, most recently
from
January 29, 2025 05:31
9a9226b
to
e809223
Compare
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
from
January 29, 2025 05:31
e809223
to
7421708
Compare
2 tasks
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
from
January 29, 2025 18:26
2d54413
to
d3b2f1c
Compare
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
from
January 29, 2025 18:42
d3b2f1c
to
c0033a7
Compare
azliu0
force-pushed
the
azliu/pty-shell-resize
branch
from
January 29, 2025 19:11
f397a4f
to
d6bcfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Very minor QoL improvement: support resizing the terminal window in
pty-shell
.Implementation detail
It'd be cleaner to create the
WindowSizeHandler
inside of theContainerProcess
handle, but signal modifications must happen in the main thread / event loop. Synchronicity forces all apis wrapped insynchronize_api
to execute in a different thread, hence the need to createWindowSizeHandler
externally and pass it in as an arg toattach
.Server pr
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog