Rename SandboxSnapshotFromId to SandboxSnapshotGet #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azliu0
force-pushed
the
azliu/rename-sandbox-snapshot-from-id
branch
from
f6d0c0f to
2677fe8
Compare
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
kramstrom
added a commit
that referenced
this pull request
Jan 27, 2025
kramstrom
added a commit
that referenced
this pull request
Jan 27, 2025
add test typing.Annotated Rename SandboxSnapshotFromId to SandboxSnapshotGet (#2800) rename SandboxSnapshotFromId [auto-commit] [skip ci] Bump the build number Enable sandbox tests on mac (#2808) * Enable sandbox tests on mac * update scheduler placement test * remove unused import [auto-commit] [skip ci] Bump the build number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
https://github.com/modal-labs/modal/pull/19130#discussion_r1927396922
Nothing in production yet, so should be safe to merge
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.