Strike mention of vestigial class from error message #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
force-pushed
the
michael/2025-01-23-update-app-image-error
branch
from
aea3882 to
98a29e2
Compare
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
freider
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Hehe yeah, synchronicity used to generate distinct types for sync vs async interfaces, so when using async you'd always have to use AioImage etc.
It had its advantages (not being able to accidentally use blocking methods if some async method returned an async type). Don't actually remember all of the reasoning for merging the objects, but I think one reason was that de-serialization of serialized Modal objects was hard to get consistently working like users wanted (i.e. should a serialized *Image be decoded as an Image or an AioImage?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't even know
AioImagewas a thing! 😁