Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for concurrency info #2746

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

erikbern
Copy link
Contributor

Following up on #2745. I realized we actually have integration tests for this in the proprietary repo! But those are slow and are much better as isolated tests like this. So I quickly ported them over to the client instead.

@erikbern erikbern requested a review from freider January 10, 2025 14:42
@erikbern
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @freider will follow-up review this.

@erikbern erikbern merged commit 4fffa57 into main Jan 10, 2025
23 checks passed
@erikbern erikbern deleted the erikbern/concurrency-info-tests branch January 10, 2025 14:42
Copy link
Contributor

@freider freider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants