Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallbacks related to container arguments #2721

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Jan 3, 2025

This removes a bunch of code that should in theory be dead.

  1. Assume we can always read the container arguments from the MODAL_CONTAINER_ARGUMENTS_PATH file
  2. Assume that the app layout is always passed to the container as a part of that

We need fallback 1 for another couple of days just waiting for all workers to roll over.

Having fallback 2 has been incredibly useful over the last few weeks because we had to revert a bunch of server changes.

So I'm a bit nervous about merging this. Planning to let this PR sit for a few weeks and then merge it assuming things are good.

@erikbern erikbern requested a review from mwaskom January 14, 2025 17:50
@erikbern
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@erikbern
Copy link
Contributor Author

I think it's time to burn the bridges and ship this. Haven't run into any issues with the app layout for a few weeks now.

@erikbern erikbern merged commit 580929c into main Jan 14, 2025
22 checks passed
@erikbern erikbern deleted the erikbern/remove-fallbacks branch January 14, 2025 17:51
@mwaskom
Copy link
Contributor

mwaskom commented Jan 14, 2025

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants