Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vendored cloudpickle to 3.1 #2716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade vendored cloudpickle to 3.1 #2716

wants to merge 1 commit into from

Conversation

aksh-at
Copy link
Contributor

@aksh-at aksh-at commented Dec 30, 2024 •
edited
Loading

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.

Changelog

@aksh-at aksh-at requested a review from mwaskom December 30, 2024 13:51
mwaskom
mwaskom approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the docstring, which encodes the cloudpickle version? (GitHub won't let me comment directly on the relevant line, I guess to be paternalistic about review scope 😁).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwaskom mwaskom mwaskom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aksh-at @mwaskom