Have client retry lost inputs #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rculbertson
changed the title
rculbertson
force-pushed
the
ryan/remote-lost-inputs
branch
2 times, most recently
from
076f198 to
33ebf45
Compare
rculbertson
force-pushed
the
ryan/remote-lost-inputs
branch
from
33ebf45 to
974171e
Compare
rculbertson
force-pushed
the
ryan/remote-lost-inputs
branch
from
974171e to
53250c3
Compare
|
@gongy This is now has all the changes we discussed. |
2 tasks
gongy
reviewed
Jan 2, 2025
rculbertson
force-pushed
the
ryan/remote-lost-inputs
branch
from
7ee0fa7 to
da026e4
Compare
Co-authored-by: Richard Gong <[email protected]>
rculbertson
force-pushed
the
ryan/remote-lost-inputs
branch
from
da026e4 to
07dad3a
Compare
|
@prbot autoapprove |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
@gongy I think you already review this last week and gave me a +1 over slack. Mind marking it as approved? |
rohansingh
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SVC-224
Update client to retry inputs if FunctionGetOutputs reports that an input is lost. If an input is lost, FunctionGetOutputs returns a failed output with status
GENERIC_STATUS_INTERNAL_FAILURE. The client then retries immediately.Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog