Only check if returned object ID is different from existing_object_id for functions #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
👍 |
erikbern
reviewed
Nov 28, 2024
| if ( | ||
| not obj._is_another_app | ||
| and existing_object_id is not None | ||
| and existing_object_id.startswith("fu-") |
There was a problem hiding this comment.
There's a helper function for this, see the _object base class!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check if returned object ID is different from existing_object_id for functions.
Currently only functions and classes use
existing_object_idin function/class creation RPCs.After the server-side fix here, ID of an existing class might change if the set of methods of the class change.
existing function IDs should not change because the way we modify functions is by assigning them a new definition id