Check that environment exists when setting in config #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
commented
Nov 26, 2024
| @@ -268,7 +268,7 @@ def __repr__(self): | |||
| return repr(self.to_dict()) | |||
|
|
|||
| def to_dict(self): | |||
| return {key: self.get(key) for key in _SETTINGS.keys()} | |||
| return {key: self.get(key) for key in sorted(_SETTINGS)} | |||
There was a problem hiding this comment.
Not directly related but when confirming that we can still set a valid environment I noticed that the modal config show output was hard to read because it was unordered.
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super simple, fixes #2086
Changelog
modal config set-environmentwill now raise if the requested environment does not exist.