Separate "indexed objects" by type #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
approved these changes
Nov 26, 2024
| return self._indexed_objects | ||
| deprecation_warning( | ||
| (2024, 11, 25), | ||
| "`app.indexed_objects` is deprecated! Use `app.registered_functions` or `app.registered_classes` instead.", |
There was a problem hiding this comment.
I think we might be planning on deprecating those too? 😁
mwaskom
reviewed
Nov 26, 2024
| @@ -177,7 +177,8 @@ def foo(): | |||
|
|
|||
| _name: Optional[str] | |||
| _description: Optional[str] | |||
| _indexed_objects: Dict[str, _Object] | |||
| _functions: Dict[str, _Function] | |||
| _classes: Dict[str, _Cls] | |||
There was a problem hiding this comment.
classes? Or ... clses? 🤔 😭
There was a problem hiding this comment.
yeah idk, no strong feelings
|
will continue sporadically over the next few weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few
Dict[str, _Object]where the object is either a function or a class. It makes sense to separate these by type. Starting withApp.indexed_objects. I'll doRunning_app.tag_to_object_idlater.