Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Proxy support to Sandboxes #2551

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

luiscape
Copy link
Member

Allows for Sandboxes to use Proxies.

Allows for Sandboxes to use Proxies.
@luiscape luiscape requested review from mwaskom and pawalt November 21, 2024 15:23
@luiscape luiscape self-assigned this Nov 21, 2024
@luiscape luiscape marked this pull request as draft November 21, 2024 15:26
@luiscape luiscape marked this pull request as ready for review November 27, 2024 16:23
Copy link
Member

@pawalt pawalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should probably wait for worker changes to fully roll before merging

@luiscape luiscape merged commit fb6eb81 into main Dec 2, 2024
22 checks passed
@luiscape luiscape deleted the luis/add-proxies-to-sandboxes branch December 2, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants