Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single_object_id from AppSetObjectsRequest #2535

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Remove single_object_id from AppSetObjectsRequest #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba98bb
Remove single_object_id from AppSetObjects
erikbern Nov 19, 2024
db5ff17
Fix test
erikbern Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ message AppSetObjectsRequest {
string client_id = 3;
repeated string unindexed_object_ids = 4;
AppState new_app_state = 5; // promotes an app from initializing to this new state
string single_object_id = 6;
reserved 6;
}

message AppStopRequest {
Expand Down
3 changes: 0 additions & 3 deletions test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ def __init__(self, blob_host, blobs, credentials):
}
]
self.app_objects = {}
self.app_single_objects = {}
self.app_unindexed_objects = {
"ap-1": ["im-1", "vo-1"],
}
Expand Down Expand Up @@ -485,8 +484,6 @@ async def AppSetObjects(self, stream):
request: api_pb2.AppSetObjectsRequest = await stream.recv_message()
self.app_objects[request.app_id] = dict(request.indexed_object_ids)
self.app_unindexed_objects[request.app_id] = list(request.unindexed_object_ids)
if request.single_object_id:
self.app_single_objects[request.app_id] = request.single_object_id
self.app_set_objects_count += 1
if request.new_app_state:
self.app_state_history[request.app_id].append(request.new_app_state)
Expand Down
Loading