Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io streams types #2533

Merged
merged 25 commits into from
Nov 20, 2024
Merged

io streams types #2533

merged 25 commits into from
Nov 20, 2024

Conversation

freider
Copy link
Contributor

@freider freider commented Nov 19, 2024

Double checked some type stuff locally using pyright and figured I could just fix the few outstanding issues and add io_streams.py to the ci-checked pyright allowlist

Base automatically changed from azliu/sb-exec-modes to main November 19, 2024 13:04
@freider freider requested a review from azliu0 November 20, 2024 10:08
@freider
Copy link
Contributor Author

freider commented Nov 20, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @azliu0 will follow-up review this.

@freider freider merged commit 77859a7 into main Nov 20, 2024
21 checks passed
@freider freider deleted the freider/io-streams-types branch November 20, 2024 10:09
Copy link
Contributor

@azliu0 azliu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants