Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of method placeholder functions #2364

Merged
merged 180 commits into from
Nov 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
180 commits
Select commit Hold shift + click to select a range
d4c2782
Miscellaneous cleanup of @app.cls code
devennavani Oct 20, 2024
bc850a1
More cleanup
devennavani Oct 20, 2024
1511cc9
Add comment
devennavani Oct 20, 2024
bc52e38
More cleanup
devennavani Oct 20, 2024
a0e5bc0
Add class method webhook configs to definition of class service function
devennavani Oct 20, 2024
04f5496
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 21, 2024
dcb9a8b
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 21, 2024
b4e736b
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 21, 2024
035b1bc
fix merge coflict
devennavani Oct 25, 2024
c0ff217
wip
devennavani Oct 25, 2024
d6d1142
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 25, 2024
5414a36
stage
devennavani Oct 25, 2024
bc6bd79
wip
devennavani Oct 27, 2024
bd90f9f
wip
devennavani Oct 27, 2024
b3aa81d
fix bugs
devennavani Oct 27, 2024
033dff7
bug fix
devennavani Oct 27, 2024
283c958
FunctionType fixes
devennavani Oct 27, 2024
f0de58e
code cleanup
devennavani Oct 27, 2024
08afd9a
protoc changes
devennavani Oct 27, 2024
f95b8a3
fixes
devennavani Oct 28, 2024
916eb9f
fixes
devennavani Oct 28, 2024
29f0cf6
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 28, 2024
59b7668
functions cleanup
devennavani Oct 28, 2024
91d4b4c
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 28, 2024
1d81bb8
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 28, 2024
2c45527
CopyFrom fix
devennavani Oct 28, 2024
0e56501
fixes from testing
devennavani Oct 28, 2024
79df7dd
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 29, 2024
80e751d
Fix Cls.lookup
devennavani Oct 29, 2024
2c62b8f
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 29, 2024
0d2e96e
proto changes for class_get_handle_metadata to handle old clients
devennavani Oct 29, 2024
3d6f120
remove extraneous space
devennavani Oct 29, 2024
f0aad3f
add method_definitions_set to function proto
devennavani Oct 29, 2024
735792f
Include only_class_function in requests
devennavani Oct 29, 2024
18711a6
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 30, 2024
17b2eb3
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 30, 2024
4473f4d
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 30, 2024
4f0b2b1
support lookup from new clients
devennavani Oct 30, 2024
42d99ad
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 31, 2024
6fcb498
Support new client looking up 0.62 class
devennavani Oct 31, 2024
9e8c2a9
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 31, 2024
7215fba
obj init cleanup
devennavani Oct 31, 2024
8b6fe60
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Oct 31, 2024
223aae2
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 1, 2024
f089aa9
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 1, 2024
656b999
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 1, 2024
c38f050
Fix merge coflicts
devennavani Nov 4, 2024
1b02192
Remove duplicate MessageDefinition
devennavani Nov 4, 2024
5748499
Fix merge conflicts
devennavani Nov 5, 2024
55cd50d
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 6, 2024
248b446
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 6, 2024
c63621f
Make tag parameter non-optional in from_name and lookup for Function …
devennavani Nov 6, 2024
2f287d9
Merge branch 'deven/make_tag_parameter_non_optional' into deven/add_m…
devennavani Nov 6, 2024
d714065
fix merge conflict
devennavani Nov 8, 2024
7ff4d7a
fix merge conflict
devennavani Nov 12, 2024
8b99874
fix merge conflict
devennavani Nov 13, 2024
289d05b
Add util to get api_pb2.Function.FunctionType from is_generator
devennavani Nov 13, 2024
e291110
fix merge conflicts
devennavani Nov 13, 2024
1fd397a
fix type check
devennavani Nov 13, 2024
2cf1dfb
fix type check
devennavani Nov 13, 2024
6820379
is_generator can be None
devennavani Nov 13, 2024
8603419
add quotes
devennavani Nov 13, 2024
4f03e92
fix merge conflict
devennavani Nov 13, 2024
f766f0e
fix merge conflicts
devennavani Nov 14, 2024
1571203
cleanup
devennavani Nov 14, 2024
32ee93a
Send method definitions in FunctionPrecreateRequest
devennavani Nov 14, 2024
5197215
Can't pass null webhook_config to CopyFrom
devennavani Nov 14, 2024
bcdf8eb
fix typo
devennavani Nov 14, 2024
2d21c34
fix merge conflicts
devennavani Nov 14, 2024
e354099
Add _method_functions attribute to _Function
devennavani Nov 14, 2024
5cab92a
fix unbound error
devennavani Nov 14, 2024
2e1cce6
update comment
devennavani Nov 14, 2024
27fa0f9
fix merge conflicts
devennavani Nov 14, 2024
d16ccc7
remove bind_method_old
devennavani Nov 14, 2024
ec89499
cleanup
devennavani Nov 14, 2024
57e1151
Merge branch 'main' into deven/add_method_functions_to_function
devennavani Nov 14, 2024
9fe8165
Hydrate _method_functions on _Function
devennavani Nov 14, 2024
bd6c83a
fix merge conflict
devennavani Nov 14, 2024
effea0d
Merge branch 'deven/send_method_definitions_in_function_precreate' in…
devennavani Nov 14, 2024
1898632
Merge branch 'deven/add_method_functions_to_function' into deven/hydr…
devennavani Nov 14, 2024
62494b9
Merge branch 'main' into deven/send_method_definitions_in_function_pr…
devennavani Nov 15, 2024
5b8ae61
Update mock FunctionPrecreate
devennavani Nov 15, 2024
1a157b6
Merge branch 'deven/send_method_definitions_in_function_precreate' in…
devennavani Nov 15, 2024
01949c7
fix merge conflict
devennavani Nov 15, 2024
9498022
Merge branch 'deven/add_method_functions_to_function' into deven/hydr…
devennavani Nov 15, 2024
64f3811
fix merge conflicts
devennavani Nov 15, 2024
7fe211f
Merge branch 'main' into deven/hydrate_method_functions
devennavani Nov 15, 2024
1b8bda0
Merge branch 'deven/hydrate_method_functions' into deven/add_method_w…
devennavani Nov 15, 2024
239a23d
Populate FunctionHandleMetadata.method_handle_metadata in _Function _…
devennavani Nov 15, 2024
0157938
fix merge conflicts
devennavani Nov 15, 2024
a11f647
fix type checks
devennavani Nov 15, 2024
5f55097
Merge branch 'deven/update_function_get_metadata' into deven/add_meth…
devennavani Nov 15, 2024
5979da6
Merge branch 'main' into deven/update_function_get_metadata
devennavani Nov 15, 2024
0fe42a3
Merge branch 'deven/update_function_get_metadata' into deven/add_meth…
devennavani Nov 15, 2024
8c1bb09
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 15, 2024
1157219
Remove extraneous changes
devennavani Nov 15, 2024
611ed93
cleanup
devennavani Nov 15, 2024
bf7dac8
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 15, 2024
4502e2b
Add _is_web_endpoint to _Function
devennavani Nov 15, 2024
b9cb233
fix merge conflicts
devennavani Nov 15, 2024
6dc8a72
dont modify _add_function
devennavani Nov 15, 2024
e6c6c9f
Merge branch 'deven/add_is_web_endpoint_to_function' into deven/add_m…
devennavani Nov 15, 2024
c260a93
add web endpoints for methods
devennavani Nov 15, 2024
3886d51
fix bug in mock FunctionPrecreate
devennavani Nov 15, 2024
d003af1
fix method_functions lookup for build function
devennavani Nov 17, 2024
7f6d475
fix tests
devennavani Nov 17, 2024
d664055
more fixes
devennavani Nov 18, 2024
1e62bd9
fix issue
devennavani Nov 18, 2024
4080e57
override properly
devennavani Nov 18, 2024
22eb509
fix parameter name
devennavani Nov 18, 2024
544f5bc
more fixes
devennavani Nov 18, 2024
5d50cd1
more test fixes
devennavani Nov 18, 2024
9d2b9f2
more fixes
devennavani Nov 18, 2024
b7be1ac
Merge branch 'main' into deven/add_is_web_endpoint_to_function
devennavani Nov 18, 2024
f90b22d
Have _Function override _Object _hydrate method
devennavani Nov 18, 2024
022d640
Merge branch 'deven/have_function_override_hydrate' into deven/add_me…
devennavani Nov 18, 2024
0978ed4
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 18, 2024
d1e7d8a
corrections
devennavani Nov 18, 2024
8a7c9f2
more fixes
devennavani Nov 18, 2024
7685d63
cleanup
devennavani Nov 18, 2024
4efafa1
more cleanup
devennavani Nov 18, 2024
8400fb1
cleanup
devennavani Nov 18, 2024
f4ff8cd
cleanup
devennavani Nov 18, 2024
2627cb3
fix type error
devennavani Nov 18, 2024
85699d3
values() -> items()
devennavani Nov 18, 2024
7271966
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 18, 2024
cc7496e
Fix mock FunctionPrecreate
devennavani Nov 18, 2024
978b034
fix FunctionCreate
devennavani Nov 18, 2024
a5c93b9
fix test_web_cls
devennavani Nov 18, 2024
106c711
another fix
devennavani Nov 18, 2024
504be62
Bring mock FunctionCreate to parity with server
devennavani Nov 18, 2024
f859f51
fix merge conflcit
devennavani Nov 18, 2024
527d912
Add method_handle_metadata attr to _Function
devennavani Nov 18, 2024
77fe7ac
Merge branch 'deven/add_method_handle_metadata_attr_to_function' into…
devennavani Nov 18, 2024
c0df225
Remove _method_functions from _Function
devennavani Nov 18, 2024
b9be7ad
Merge branch 'deven/remove_method_functions_from_function' into deven…
devennavani Nov 18, 2024
f3a819c
remove redundant line
devennavani Nov 18, 2024
cf185a3
Merge branch 'main' into deven/add_method_handle_metadata_attr_to_fun…
devennavani Nov 18, 2024
1cc2bce
Merge branch 'deven/add_method_handle_metadata_attr_to_function' into…
devennavani Nov 18, 2024
d262999
Merge branch 'deven/remove_method_functions_from_function' into deven…
devennavani Nov 18, 2024
f5ff857
fix merge conflict
devennavani Nov 18, 2024
6efc9b4
Merge branch 'deven/remove_method_functions_from_function' of https:/…
devennavani Nov 18, 2024
cd851a2
Merge branch 'deven/remove_method_functions_from_function' into deven…
devennavani Nov 18, 2024
66b7d1c
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 18, 2024
49acb6c
fix modal shell maybe
devennavani Nov 18, 2024
28c98d1
fix cli tests
devennavani Nov 18, 2024
049e148
undo some unnecessary formatting
devennavani Nov 18, 2024
b4dbed2
undo more unnecessary formatting
devennavani Nov 18, 2024
5960950
fix type check
devennavani Nov 18, 2024
da6453c
fix tests
devennavani Nov 18, 2024
d628942
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 19, 2024
f43f426
Bump minor number
devennavani Nov 19, 2024
0c6dd03
fix bug in cls hydrate metadata
devennavani Nov 19, 2024
1b2680c
fix merge conflict
devennavani Nov 20, 2024
ef52754
dont set use_function_id on instance service function method function
devennavani Nov 20, 2024
32f2485
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 20, 2024
971823e
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 20, 2024
139d63a
remove print statement
devennavani Nov 20, 2024
eaecbdc
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 20, 2024
6ff7335
url display changes
devennavani Nov 21, 2024
46b654a
use arrow
devennavani Nov 21, 2024
f0ef776
fix merge conflict
devennavani Nov 21, 2024
16fde81
undo some changes
devennavani Nov 21, 2024
7508f4d
Show urls for modal domains and custom domains for web endpoint metho…
devennavani Nov 21, 2024
3885f94
fix merge conflict"
devennavani Nov 21, 2024
2c89765
Merge branch 'main' into deven/show_urls_for_new_style_class_methods
devennavani Nov 21, 2024
33fcc06
Merge branch 'main' into deven/show_urls_for_new_style_class_methods
devennavani Nov 21, 2024
2766df5
Merge branch 'deven/show_urls_for_new_style_class_methods' into deven…
devennavani Nov 21, 2024
5176514
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 21, 2024
24bf4d4
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 21, 2024
ce79aea
bug fix
devennavani Nov 21, 2024
e3cb65d
Merge branch 'main' into deven/add_method_webhook_configs_to_class_fu…
devennavani Nov 22, 2024
fa9554c
add test coverage
devennavani Nov 23, 2024
720aa55
edit build_number
devennavani Nov 23, 2024
1b4d2f0
fix merge conflict
devennavani Nov 25, 2024
19e63fc
fix merge conflict
devennavani Nov 26, 2024
818d3ff
merge conflict
devennavani Nov 27, 2024
0cf5156
bump version generated
devennavani Nov 27, 2024
407b723
fix build number
devennavani Nov 27, 2024
1d606b6
address nits
devennavani Nov 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build number
devennavani committed Nov 27, 2024
commit 407b7238205d077438309fc1737c61f358f90569
2 changes: 1 addition & 1 deletion modal_version/_version_generated.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright Modal Labs 2024

# Note: Reset this value to -1 whenever you make a minor `0.X` release of the client.
build_number = -1 # git: 2903bbe
build_number = -1 # git: a1760e2
You are viewing a condensed version of this merge commit. You can view the full changes here.