Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda deprecation warning->error #2356

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Oct 18, 2024

Removed the implementation here but forgot to upgrade the warning to an error!

(I did it correctly for the other two conda methods; it would have been very hard to run into this).

@mwaskom mwaskom requested a review from devennavani October 18, 2024 17:50
@mwaskom
Copy link
Contributor Author

mwaskom commented Oct 18, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @devennavani will follow-up review this.

@mwaskom mwaskom merged commit 14f30ef into main Oct 18, 2024
22 checks passed
@mwaskom mwaskom deleted the michael/fix-conda-deprecation branch October 18, 2024 17:54
Copy link
Contributor

@devennavani devennavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants