Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire deprecation of modal volume delete --confirm #2355

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Oct 18, 2024

Changelog

  • The previously-deprecated --confirm flag has been removed from the modal volume delete CLI. Use --yes to force deletion without a confirmation prompt.

@mwaskom mwaskom requested a review from devennavani October 18, 2024 16:27
@mwaskom
Copy link
Contributor Author

mwaskom commented Oct 18, 2024

@prbot lgtm

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @devennavani will follow-up review this.

@mwaskom mwaskom merged commit 16eebe9 into main Oct 18, 2024
22 checks passed
@mwaskom mwaskom deleted the michael/expire-volume-confirm-deprecation branch October 18, 2024 16:28
Copy link
Contributor

@devennavani devennavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants