Fix i6pn main address being None (typo) #2351
Conversation
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
@prbot approve |
| @@ -159,7 +159,7 @@ def wrapper(*args, **kwargs): | |||
|
|
|||
| def get_i6pn(): | |||
| """Returns the ipv6 address assigned to this container.""" | |||
| socket.getaddrinfo("i6pn.modal.local", None, socket.AF_INET6)[0][4][0] | |||
| return socket.getaddrinfo("i6pn.modal.local", None, socket.AF_INET6)[0][4][0] | |||
There was a problem hiding this comment.
[0][4][0]is very confusing to me. Could you create named variables? :)
There was a problem hiding this comment.
I think there was some discussion here about this. Personally I agree with Eric that [0][4][0] is something that can just be black-boxed (which was sort of the goal of the get_i6pn() function -- readers just need to know that the function returns the ipv6 address and don't need to know how it's done).
I'm open to other ideas though! In particular, I don't even know what to name the variables if I were to make each one a variable.
There was a problem hiding this comment.
Got it. Magic incantations without comments will likely trigger questions from every unfamiliar reader. Imo it's either "literate programming" or adding comments to the source.
I forgot to add a
returnstatement.This wasn't caught in code review because I made the change after the PR was approved and somehow didn't catch the error myself :(
e2e tests failed on the main Modal repo, which is how I noticed this issue.