Don't sleep before sending an exec request #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying bug that requires this sleep has been fixed.
irfansharif
approved these changes
Oct 16, 2024
| @@ -388,8 +388,8 @@ async def _get_task_id(self): | |||
| while not self._task_id: | |||
| resp = await self._client.stub.SandboxGetTaskId(api_pb2.SandboxGetTaskIdRequest(sandbox_id=self.object_id)) | |||
| self._task_id = resp.task_id | |||
| # TODO: debug why sending an exec right after a task ID exists fails silently | |||
| await asyncio.sleep(0.5) | |||
| if not self._task_id: | |||
There was a problem hiding this comment.
When do we not get a task ID back, and why are we sleeping for those cases? How come we're not removing the sleep completely?
There was a problem hiding this comment.
We shouldn't hammer the RPC - it would hot loop otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying bug that requires this sleep has been fixed.
Describe your changes
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.