-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOD-2454: remove aiostream dependency: async_merge #2344
Merged
kramstrom
merged 8 commits into
main
from
kramstrom/mod-2454-remove-aiostream-dependency-async_merge
Oct 17, 2024
Merged
MOD-2454: remove aiostream dependency: async_merge #2344
kramstrom
merged 8 commits into
main
from
kramstrom/mod-2454-remove-aiostream-dependency-async_merge
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freider
reviewed
Oct 16, 2024
freider
reviewed
Oct 16, 2024
freider
reviewed
Oct 16, 2024
kramstrom
changed the title
[WIP] MOD-2454: remove aiostream dependency: async_merge
MOD-2454: remove aiostream dependency: async_merge
Oct 16, 2024
@prbot autoapprove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍. @freider will follow-up review this.
kramstrom
deleted the
kramstrom/mod-2454-remove-aiostream-dependency-async_merge
branch
October 17, 2024 08:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue splitting #2320 up into multiple PRs as it grew quite big. This adds
async_merge
. Also ran integration tests that passed