Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOD-2454: remove aiostream dependency: async_merge #2344

Merged

Conversation

kramstrom
Copy link
Contributor

@kramstrom kramstrom commented Oct 16, 2024

continue splitting #2320 up into multiple PRs as it grew quite big. This adds async_merge. Also ran integration tests that passed

@kramstrom kramstrom requested a review from freider October 16, 2024 13:27
@kramstrom kramstrom marked this pull request as ready for review October 16, 2024 13:27
modal/functions.py Outdated Show resolved Hide resolved
modal/parallel_map.py Outdated Show resolved Hide resolved
test/async_utils_test.py Outdated Show resolved Hide resolved
@kramstrom kramstrom changed the title [WIP] MOD-2454: remove aiostream dependency: async_merge MOD-2454: remove aiostream dependency: async_merge Oct 16, 2024
@kramstrom kramstrom requested a review from freider October 17, 2024 07:52
@kramstrom
Copy link
Contributor Author

@prbot autoapprove

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @freider will follow-up review this.

@kramstrom kramstrom merged commit 5610347 into main Oct 17, 2024
21 checks passed
@kramstrom kramstrom deleted the kramstrom/mod-2454-remove-aiostream-dependency-async_merge branch October 17, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants