MOD-4118: handle deserialization errors #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kramstrom
force-pushed
the
kramstrom/mod-4118-deserialization-errors-shouldnt-terminate-entire-containers
branch
from
8803b51 to
0bbbf63
Compare
kramstrom
force-pushed
the
kramstrom/mod-4118-deserialization-errors-shouldnt-terminate-entire-containers
branch
from
0bbbf63 to
f77a035
Compare
…ouldnt-terminate-entire-containers
erikbern
reviewed
Oct 16, 2024
| input_id="in-xyz0", | ||
| function_call_id="fc-123", | ||
| input=api_pb2.FunctionInput( | ||
| args=b"\x80\x04\x95(\x00\x00\x00\x00\x00\x00\x00\x8c\x17", |
There was a problem hiding this comment.
instead of a byte string here, can you feed it a pickled object? or is that impossible because it needs to be a different package?
There was a problem hiding this comment.
yeah would have to somehow pickle the object in another venv than it's being pickled in which sounds annoying but more realistic, but both of these causes serialization errors
…ouldnt-terminate-entire-containers
gongy
approved these changes
Oct 17, 2024
kramstrom
deleted the
kramstrom/mod-4118-deserialization-errors-shouldnt-terminate-entire-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves deserialization for inputs to after constructor to ensure we handle user exceptions and don't retry them -- likely regression from #2081