Skip to content

Commit

Permalink
Change last_index to a uint64 (#1248)
Browse files Browse the repository at this point in the history
This is a minor inconsistency with DataChunk's index field.

It remains backwards-compatible because uint32 and uint64 have the same wire protocol. https://protobuf.dev/programming-guides/encoding/
  • Loading branch information
ekzhang authored Jan 26, 2024
1 parent e872b28 commit 15ad59e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modal_proto/api.proto
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ message FunctionCallPutDataRequest {

message FunctionCallGetDataRequest {
string function_call_id = 1;
uint32 last_index = 2;
uint64 last_index = 2;
}

message Function {
Expand Down Expand Up @@ -1872,4 +1872,4 @@ service ModalClient {

// Workspaces
rpc WorkspaceNameLookup(google.protobuf.Empty) returns (WorkspaceNameLookupResponse);
}
}

0 comments on commit 15ad59e

Please sign in to comment.