-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of linter rules messages #5470
Draft
felipecrs
wants to merge
3
commits into
moby:master
Choose a base branch
from
felipecrs:improve-ruleset-messages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+46
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Santos <[email protected]>
Some patterns I came up with:
|
dvdksn
reviewed
Oct 31, 2024
felipecrs
commented
Oct 31, 2024
felipecrs
force-pushed
the
improve-ruleset-messages
branch
from
October 31, 2024 13:58
8bf8834
to
277b129
Compare
Signed-off-by: Felipe Santos <[email protected]>
felipecrs
force-pushed
the
improve-ruleset-messages
branch
from
October 31, 2024 13:59
277b129
to
6d26769
Compare
…e-ruleset-messages Signed-off-by: Felipe Santos <[email protected]>
felipecrs
force-pushed
the
improve-ruleset-messages
branch
from
October 31, 2024 14:01
0a33254
to
7438264
Compare
@felipecrs I think the test cases will also need to be updated. 🙏 |
For sure @thompson-shaun, I will get around to doing it soon. Please leave this on standby until I update it. Sorry. |
No worries! Just wanted to call out in case it got lost in the pile. Thank you for the contribution. Reach out if you need assistance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spend some time reviewing the messages of these rules, and I found some little inconsistencies in the style. In my opinion this PR improves them.