Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update undefined var check reference #5449

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Oct 23, 2024

Updates the checks reference for the UndefinedVar rule to clarify the following:

  • Variables declared in base images are considered valid (no warn)
  • This rule does not apply to shell form instructions

Related issues

@crazy-max
Copy link
Member

Looks like a legitimate ci failure: https://github.com/moby/buildkit/actions/runs/11496293740/job/31997650750?pr=5449#step:5:391

------
 > [validate 1/1] RUN --mount=target=/context   --mount=target=.,type=tmpfs <<EOT (set -e...):
0.773 ERROR: Dockerfile docs result differs. Please update with "make docs-dockerfile"
0.795  M frontend/dockerfile/docs/rules/undefined-var.md

@crazy-max crazy-max added this to the v0.17.0 milestone Oct 25, 2024
Signed-off-by: David Karlsson <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
@tonistiigi tonistiigi merged commit cda279e into moby:master Oct 28, 2024
93 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants