Add/fix references to labs dockerfile version #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COPY options `--parents` and `--exclude` require dockerfile version `1.7-labs`. Existing table of options only lists required version as `1.7`. Code examples for `--exclude` does not include syntax line, like is included in the code examples for `--parents`. Signed-off-by: Eoin Farrell <[email protected]>
dvdksn
suggested changes
Oct 23, 2024
There was a problem hiding this comment.
Thank you for catching this. Two things that came to my mind:
-
I think we should probably just use
1-labsin these examples, rather than1.7-labs.-
I noticed that we use
1.7-labsin theCOPY --parentsexample. Could you update that one to use1-labsinstead?buildkit/frontend/dockerfile/docs/reference.md
Line 1823 in 3eb4892
-
-
The
ADD --excludeoption also states1.7, but it should also e1.7-labs.buildkit/frontend/dockerfile/docs/reference.md
Line 1240 in 3eb4892
Also update examples to point syntax at 1-labs rather than 1.7-labs Signed-off-by: Eoin Farrell <[email protected]>
|
Thanks for the review @dvdksn, commit pushed to resolve your comments. |
tonistiigi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COPY options
--parentsand--excluderequire dockerfile version1.7-labs. Existing table of options only lists required version as1.7. Code examples for--excludedoes not include syntax line, like is included in the code examples for--parents.