-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: frontend/gateway: leave mount type as nil for Windows #5077
Open
billywr
wants to merge
1
commit into
moby:master
Choose a base branch
from
billywr:os-mount-types-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't forget to sign-off your commits, see this failed run. |
billywr
changed the title
Exclude Windows OS when adding bind mount types
fix: frontend/gateway:exclude Windows OS when adding bind mount types
Aug 12, 2024
billywr
changed the title
fix: frontend/gateway:exclude Windows OS when adding bind mount types
fix:Exclude Windows OS when adding bind mount types
Aug 12, 2024
billywr
changed the title
fix:Exclude Windows OS when adding bind mount types
fix: frontend/gateway: leave mount type as nil for Windows
Aug 14, 2024
billywr
force-pushed
the
os-mount-types-check
branch
from
August 14, 2024 11:28
da47264
to
2ef7a45
Compare
billywr
force-pushed
the
os-mount-types-check
branch
2 times, most recently
from
August 19, 2024 11:20
f83390c
to
534b6ff
Compare
billywr
force-pushed
the
os-mount-types-check
branch
from
August 23, 2024 10:55
534b6ff
to
dcfe789
Compare
Is this PR close to a ready state @billywr? Just wanted to make sure it didn't get lost ;) |
billywr
force-pushed
the
os-mount-types-check
branch
from
September 23, 2024 05:55
dcfe789
to
8b8061b
Compare
github-actions
bot
added
area/dockerfile
area/frontend
area/docs
and removed
area/executor
labels
Sep 23, 2024
billywr
force-pushed
the
os-mount-types-check
branch
from
September 24, 2024 05:36
8b8061b
to
1da789b
Compare
billywr
force-pushed
the
os-mount-types-check
branch
from
September 24, 2024 08:40
f6c280a
to
5abf161
Compare
billywr
force-pushed
the
os-mount-types-check
branch
from
September 24, 2024 08:41
5abf161
to
dc8561e
Compare
billywr
force-pushed
the
os-mount-types-check
branch
2 times, most recently
from
September 26, 2024 13:16
fb193ed
to
6af1547
Compare
-Added a check to exclude Windows OS when adding bind mount types to container image bundle. -Bind types apply to Linux OS; hcsshim accepts empty bind types for Windows container creation. Signed-off-by: Billy Owire <[email protected]>
billywr
force-pushed
the
os-mount-types-check
branch
from
October 28, 2024 05:43
6af1547
to
e45cdd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to exclude Windows OS when adding bind mount types to container image bundle.
Bind types apply to Linux OS; hcsshim accepts empty bind types for Windows container creation.
#4892
More info, what I was trying to achieve
I attempted to build a custom Docker frontend image(resides in dockerhub:docker.io/100909/dockerfile-4892) using the following Dockerfile:
The
dockerfile-frontend.exe
was built frombuildkit/frontend/dockerfile/cmd/dockerfile-frontend
.I created another Dockerfile referencing the custom frontend image:
# syntax=docker.io/100909/dockerfile-4892
I ran the following command:
This resulted in an error during container creation in
hcsshim
:I made changes in BuildKit to fix the error in step 3 and ran
buildctl
again.Container creation stage passes,
I am getting a new error shown below when building the custom dockerfile frontend as in step 2.
sh error: failed to solve: exit code: 2
This commit fixes the error in step 3.
@tonistiigi I am seeking ideas and comments.