Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECMA private fields with auto-accessor are in fact supported #4214

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

creasty
Copy link
Contributor

@creasty creasty commented Jan 30, 2025

Code change checklist

  • [-] Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • [-] Verified that there is no significant performance drop (yarn mobx test:performance)

Why

Needs clarification.

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: b3b060c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mweststrate
Copy link
Member

Great catch, thanks!

@mweststrate mweststrate merged commit b06024d into mobxjs:main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants