-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observer excludedchild #958
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 57 57
Lines 1998 1998
=======================================
Hits 1978 1978
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a quick documentation item for the Observer: https://mobx.netlify.app/api/observers. Then we are done with the basics.
✅ Deploy Preview for mobx canceled.
|
Essentially adding a documentation note for |
Okay, I'll try. |
Ok, let's do this. We can close this PR for code and create a separate one for the docs |
I got feedback from my fellows that it's unclear that "withChild" is actually "without child"!
So I renamed
Observer.withChild
toObserver.excludedChild
.Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelos run set_version
command from the root directory