Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observer excludedchild #958

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

subzero911
Copy link
Contributor

@subzero911 subzero911 commented Nov 20, 2023

I got feedback from my fellows that it's unclear that "withChild" is actually "without child"!
So I renamed Observer.withChild to Observer.excludedChild.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #958 (9741494) into main (d7dbbf5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          57       57           
  Lines        1998     1998           
=======================================
  Hits         1978     1978           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <100.00%> (ø)
mobx 98.55% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flutter_mobx/lib/src/observer.dart 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7dbbf5...9741494. Read the comment docs.

@subzero911
Copy link
Contributor Author

@pavanpodila

flutter_mobx/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@pavanpodila pavanpodila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a quick documentation item for the Observer: https://mobx.netlify.app/api/observers. Then we are done with the basics.

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit 9741494
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/656071d0812fba0008b949b9

@pavanpodila
Copy link
Member

Can we also add a quick documentation item for the Observer: https://mobx.netlify.app/api/observers. Then we are done with the basics.

Essentially adding a documentation note for withBuiltChild factory method

@subzero911
Copy link
Contributor Author

Okay, I'll try.
But didn't edit the docs before (specifically, this MDX format).

@pavanpodila
Copy link
Member

Okay, I'll try. But didn't edit the docs before (specifically, this MDX format).

Ok, let's do this. We can close this PR for code and create a separate one for the docs

@pavanpodila pavanpodila merged commit 74e4a89 into mobxjs:main Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants