Skip to content

Commit

Permalink
fix: ObservableSet and ObservableMap should not notify all listen…
Browse files Browse the repository at this point in the history
…ers when `observe` with fireImmediately
  • Loading branch information
amondnet committed Dec 13, 2023
1 parent 34fb10a commit ef34581
Showing 1 changed file with 26 additions and 9 deletions.
35 changes: 26 additions & 9 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,27 +72,44 @@ jobs:
build_lint_packages:
runs-on: ubuntu-latest

defaults:
run:
working-directory: ${{ matrix.package }}

strategy:
matrix:
package: ["mobx_lint", "mobx_lint_flutter"]
version: ["stable"]

steps:
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
with:
channel: ${{ matrix.channel }}

- name: Add pub cache bin to PATH
run: echo "$HOME/.pub-cache/bin" >> $GITHUB_PATH
- name: Add pub cache to PATH
run: echo "PUB_CACHE="$HOME/.pub-cache"" >> $GITHUB_ENV
- name: Install dependencies
working-directory: mobx_lint
run: dart pub get
run: flutter pub get
- run: dart pub global activate custom_lint

- name: Analyze
working-directory: mobx_lint
run: dart analyze --fatal-warnings --fatal-infos .
run: flutter analyze

- name: Run custom_lint
run: custom_lint
# Workaround to https://github.com/invertase/dart_custom_lint/issues/77
if: matrix.package == 'mobx_lint_flutter_test'

- name: Run tests
working-directory: mobx_lint_flutter_test
run: |
flutter pub get
flutter test test
if: matrix.package == 'mobx_lint_flutter_test'
run: flutter test --coverage --coverage-path coverage/lcov.txt

- name: Upload coverage to codecov
uses: codecov/codecov-action@v3
if: matrix.package == 'mobx_lint_flutter_test'
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: mobx_lint
files: coverage/lcov.txt

0 comments on commit ef34581

Please sign in to comment.