Fix Firestore getDocument hang bugs #122, and also #112 due to accide…

…ntly recursive calling the function itself.
mobizt · Sep 2, 2021 · 0e1981f · 0e1981f
1 parent 1ac686d
commit 0e1981f
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # Firebase Arduino Client Library for ESP8266 and ESP32
 
 
-Google's Firebase Arduino Client Library for ESP8266 and ESP32 v2.4.4
+Google's Firebase Arduino Client Library for ESP8266 and ESP32 v2.4.5
 
 
 This library supports ESP8266 and ESP32 MCU from Espressif. The following are platforms in which the libraries are also available (RTDB only).

diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
   "name": "Firebase Arduino Client Library for ESP8266 and ESP32",
-  "version": "2.4.4",
+  "version": "2.4.5",
   "keywords": "communication, REST, esp32, esp8266, arduino",
   "description": "The library supports Firebase products e.g. Realtime database, Cloud Firestore database, Firebase Storage and Google Cloud Storage, Cloud Functions for Firebase and Cloud Messaging.",
   "repository": {

diff --git a/library.properties b/library.properties
@@ -1,6 +1,6 @@
 name=Firebase Arduino Client Library for ESP8266 and ESP32
 
-version=2.4.4
+version=2.4.5
 
 author=Mobizt
 

diff --git a/src/Firebase_ESP_Client.h b/src/Firebase_ESP_Client.h
@@ -1,19 +1,16 @@
 #ifndef FIREBASE_CLIENT_VERSION
-#define FIREBASE_CLIENT_VERSION "2.4.4"
+#define FIREBASE_CLIENT_VERSION "2.4.5"
 #endif
 
 /**
- * Google's Firebase ESP Client Main class, Firebase_ESP_Client.h v2.4.4
+ * Google's Firebase ESP Client Main class, Firebase_ESP_Client.h v2.4.5
  * 
  * This library supports Espressif ESP8266 and ESP32 MCUs
  * 
- * Created August 31, 2021
+ * Created September 3, 2021
  *
  *   Updates:
- * - Fix RTDB pushTimestamp bad request issue.
- * - Fix FCM appInstanceInfo.
- * - Update RTDB timestamp example.
- * - Update FirbaseJson RTDB client example.
+ * - Fix Firestore getDocument hang bugs #122, and also #112 due to accidently recursive calling the function itself.
  * 
  * This work is a part of Firebase ESP Client library
  * Copyright (c) 2021 K. Suwatchai (Mobizt)

diff --git a/src/README.md b/src/README.md
@@ -1,7 +1,7 @@
 # Firebase Arduino Client Library for ESP8266 and ESP32
 
 
-Google's Firebase Arduino Client Library for ESP8266 and ESP32 v2.4.4
+Google's Firebase Arduino Client Library for ESP8266 and ESP32 v2.4.5
 
 
 The default filessystem used in the library is flash and SD.

diff --git a/src/firestore/FB_Firestore.cpp b/src/firestore/FB_Firestore.cpp
@@ -1,9 +1,9 @@
 /**
- * Google's Cloud Firestore class, Forestore.cpp version 1.1.3
+ * Google's Cloud Firestore class, Forestore.cpp version 1.1.4
  * 
  * This library supports Espressif ESP8266 and ESP32
  * 
- * Created August 21, 2021
+ * Created September 3, 2021
  * 
  * This work is a part of Firebase ESP Client library
  * Copyright (c) 2021 K. Suwatchai (Mobizt)

diff --git a/src/firestore/FB_Firestore.h b/src/firestore/FB_Firestore.h
@@ -1,9 +1,9 @@
 /**
- * Google's Cloud Firestore class, Forestore.h version 1.1.3
+ * Google's Cloud Firestore class, Forestore.h version 1.1.4
  * 
  * This library supports Espressif ESP8266 and ESP32
  * 
- * Created August 21, 2021
+ * Created September 3, 2021
  * 
  * This work is a part of Firebase ESP Client library
  * Copyright (c) 2021 K. Suwatchai (Mobizt)
@@ -199,7 +199,7 @@ class FB_Firestore
      * 
     */
     template <typename T1 = const char *, typename T2 = const char *, typename T3 = const char *, typename T4 = const char *, typename T5 = const char *, typename T6 = const char *>
-    bool getDocument(FirebaseData *fbdo, T1 projectId, T2 databaseId, T3 documentPath, T4 mask = "", T5 transaction = "", T6 readTime = "") { return getDocument(fbdo, toString(projectId), toString(databaseId), toString(documentPath), toString(mask), toString(transaction), toString(readTime)); }
+    bool getDocument(FirebaseData *fbdo, T1 projectId, T2 databaseId, T3 documentPath, T4 mask = "", T5 transaction = "", T6 readTime = "") { return mGetDocument(fbdo, toString(projectId), toString(databaseId), toString(documentPath), toString(mask), toString(transaction), toString(readTime)); }
 
     /** Starts a new transaction.
      *