Fix critical issue in scaling coordinates in 2d tables

mobie · Nov 7, 2022 · edb2d9e · edb2d9e
1 parent 144b4fc
commit edb2d9e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/mobie/htm/table_impl.py b/mobie/htm/table_impl.py
@@ -125,9 +125,9 @@ def compute_table(input_file, table_path, key, resolution):
     props = regionprops(seg)
     tab = np.array([
         [p.label]
-        + [ce / res for ce, res in zip(centers[p.label], resolution)]
-        + [float(bb) / res for bb, res in zip(p.bbox[:ndim], resolution)]
-        + [float(bb) / res for bb, res in zip(p.bbox[ndim:], resolution)]
+        + [ce * res for ce, res in zip(centers[p.label], resolution)]
+        + [float(bb) * res for bb, res in zip(p.bbox[:ndim], resolution)]
+        + [float(bb) * res for bb, res in zip(p.bbox[ndim:], resolution)]
         + [p.area]
         for p in props
     ])

diff --git a/mobie/tables/default_table.py b/mobie/tables/default_table.py
@@ -37,9 +37,9 @@ def _compute_table_2d(seg_path, seg_key, resolution):
     props = regionprops(seg)
     tab = np.array([
         [p.label]
-        + [ce / res for ce, res in zip(centers[p.label], resolution)]
-        + [float(bb) / res for bb, res in zip(p.bbox[:ndim], resolution)]
-        + [float(bb) / res for bb, res in zip(p.bbox[ndim:], resolution)]
+        + [ce * res for ce, res in zip(centers[p.label], resolution)]
+        + [float(bb) * res for bb, res in zip(p.bbox[:ndim], resolution)]
+        + [float(bb) * res for bb, res in zip(p.bbox[ndim:], resolution)]
         + [p.area]
         for p in props
     ])

diff --git a/mobie/validation/metadata.py b/mobie/validation/metadata.py
@@ -161,7 +161,7 @@ def _dynamic_view_source_validation(view, sources, displays, assert_true):
             if isinstance(display_sources, dict):
                 display_sources = [source for this_sources in display_sources.values() for source in this_sources]
             wrong_sources = list(set(display_sources) - valid_sources)
-            msg = f"Found wrong sources {wrong_sources} in sourceDisplay"
+            msg = f"Found wrong sources {wrong_sources} in sourceDisplay: {display_metadata['name']}"
             assert_true(len(wrong_sources) == 0, msg)