Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toward merging with n5-imglib2 interfaces #123

Draft
wants to merge 2 commits into
base: hackathon_prague_2022
Choose a base branch
from

Conversation

bogovicj
Copy link
Contributor

  • wip toward implementing n5-imglib2 metadata interfaces

* wip toward implementing n5-imglib2 metadata interfaces
* test discoverability
* add some new constructors
@tischi
Copy link
Collaborator

tischi commented Sep 15, 2022

@bogovicj
Thank you! This looks very interesting!
Do you envision this also to look like this here: ome/ome-ngff-java#4 ?

@joshmoore, what do you think? Do we want to have an N5 dependency in https://github.com/ome/ome-ngff-java/ ?

@joshmoore
Copy link

Do we want to have an N5 dependency in https://github.com/ome/ome-ngff-java/ ?

I was thinking that ome-ngff-java as the dumbest component would be at the start of the dependency graph.

@bogovicj
Copy link
Contributor Author

bogovicj commented Sep 15, 2022

I agree with @joshmoore , I had in mind for ome-ngff-java to have no (or minimal) dependencies.
n5 stuff could depend on it, and wrap / create what they have to from the stuff here.'

re: what I did here, Multiscales probably belongs in ome-ngff-java, but I could extend it here (or n5-imglib2 or wherever) to implement SpatialMetadataGroup, which is what this PR adds

Another example: CoordinateTransformation lives in this repo, some other repo creates imglib2 RealTransforms from them.

@tischi
Copy link
Collaborator

tischi commented Sep 16, 2022

This looks great then!
Shall we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants