Skip to content

Commit

Permalink
Restore the previous dynamic import settings.
Browse files Browse the repository at this point in the history
Fix ImagingDataCommons#113 (Setup the dynamic import so it is separate from other packages)
introduced issues with the PUBLIC_URL config.
  • Loading branch information
moalsad committed Jun 9, 2024
1 parent 8857efe commit 2740921
Show file tree
Hide file tree
Showing 13 changed files with 10 additions and 14 deletions.
12 changes: 4 additions & 8 deletions config/webpack/webpack-dynamic-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const merge = require('./merge')
const rootPath = process.cwd()
const baseConfig = require('./webpack-base')
const TerserPlugin = require('terser-webpack-plugin')
const outputPath = path.join(rootPath, 'dist', 'dynamic-import', 'dicom-microscopy-viewer')
const outputPath = path.join(rootPath, 'dist', 'dynamic-import')

const prodConfig = {
mode: 'production',
Expand All @@ -12,15 +12,11 @@ const prodConfig = {
},
output: {
path: outputPath,
library: {
name: 'dicomMicroscopyViewer',
type: 'window',
},
filename: '[name].min.js',
publicPath: '/dicom-microscopy-viewer/',
libraryTarget: 'umd',
globalObject: 'this',
filename: '[name].min.js'
},
optimization: {
// minimize: false,
minimizer: [
new TerserPlugin({
parallel: true
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

3 changes: 3 additions & 0 deletions dist/dynamic-import/dicomMicroscopyViewer.min.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/dynamic-import/dicomMicroscopyViewer.min.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/dynamic-import/microscopy.worker.min.worker.js.map

Large diffs are not rendered by default.

0 comments on commit 2740921

Please sign in to comment.