Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(seeder): cannot seed if entity name is reserved word, Closes #257 #261

Merged

Conversation

brunobuddy
Copy link
Contributor

Description

fix(seeder): cannot seed if entity name is reserved word, Closes #257

Related Issues

How can it be tested?

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

@brunobuddy brunobuddy linked an issue Jan 9, 2025 that may be closed by this pull request
@brunobuddy brunobuddy merged commit 9626c51 into master Jan 9, 2025
6 checks passed
@brunobuddy brunobuddy deleted the 257-failing-if-entity-relation-name-is-same-as-entity-name branch January 9, 2025 16:09
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (87321e9) to head (9c113a7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   55.06%   56.39%   +1.32%     
==========================================
  Files          42       42              
  Lines        1204     1204              
  Branches      298      289       -9     
==========================================
+ Hits          663      679      +16     
- Misses        501      524      +23     
+ Partials       40        1      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing if entity relation name is same as entity name
1 participant