BUGFIX: return events if provided when current = desired sfreq #13070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case current sfreq equals desired sfreq
Randomidous
requested review from
drammock,
cbrnr,
agramfort,
mscheltienne and
dengemann
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
larsoner
reviewed
Jan 17, 2025
Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Eric Larson <[email protected]>
…python into resample_events
|
@larsoner Done! Test added under |
for more information, see https://pre-commit.ci
larsoner
reviewed
Jan 17, 2025
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
|
Thanks @Randomidous ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/mne-python
that referenced
this pull request
Jan 24, 2025
…urrent = desired sfreq
larsoner
pushed a commit
that referenced
this pull request
Jan 24, 2025
…ided when current = desired sfreq) (#13081) Co-authored-by: Roy Eric <[email protected]>
|
My pleasure @larsoner :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13066
What does this implement/fix?
The resample function takes an additional parameter "events" and returns a resampled copy if provided. When the current is equal to the desired sfreq, only self is returned. This fix now returns raw and events if both were provided, avoiding preprocessing pipeline bugs down the line.
Additional information
A test for this is described in the issue.