Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. #12977 #12978

Merged
merged 4 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/devel/12978.other.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a mistake in :ref:`tut-artifact-regression` where the wrong regression coefficients were applied, by :newcontrib:`Jacob Phelan`.
1 change: 1 addition & 0 deletions doc/changes/names.inc
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
.. _Ivo de Jong: https://github.com/ivopascal
.. _Jaakko Leppakangas: https://github.com/jaeilepp
.. _Jack Zhang: https://github.com/jackz314
.. _Jacob Phelan: https://github.com/JacPhe
.. _Jacob Woessner: https://github.com/withmywoessner
.. _Jair Montoya Martinez: https://github.com/jmontoyam
.. _Jan Ebert: https://www.jan-ebert.com/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
fig.set_size_inches(3, 2)

# apply the regression coefficients to the original epochs
epochs_clean_sub = model_plain.apply(epochs).apply_baseline()
epochs_clean_sub = model_sub.apply(epochs).apply_baseline()
fig = epochs_clean_sub.average("all").plot(**plot_kwargs)
fig.set_size_inches(6, 6)

Expand Down