Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: viz plot window's 'title' argument showed no effect. #12828

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

shristibaral
Copy link
Contributor

viz plot window's 'title' argument showed no effect. Fix:
if title is given, title along with subject's name will be displayed on plot window title, if title is none then subject name will be displayed as title.

Reference issue

Example: Fixes #1234.

What does this implement/fix?

Explain your changes.

Additional information

Any additional information you think is important.

viz plot window's 'title' argument showed no effect.
Fix:
if title is given, title along with subject's name will be displayed on plot window title, if title is none then subject name will be displayed as title.
Copy link

welcome bot commented Sep 5, 2024

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

@larsoner
Copy link
Member

larsoner commented Sep 6, 2024

Looks reasonable @shristibaral ! Can you add a doc/changes/devel/12828.bugfix.rst with something like:

Fixed behavior of :func:`mne.viz.plot_source_estimates` where the ``title`` was not displayed properly, by :newcontrib:`Shristi Baral`.

and then add your name to doc/changes/names.inc?

@larsoner larsoner added this to the 1.9 milestone Sep 6, 2024
@shristibaral
Copy link
Contributor Author

I have added updated docs file

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a tiny commit to add title a few more places and document it in the docstrings properly. Will mark for merge-when-green, but might take a couple of hours because we'll want to wait for #12832 to get CIs green first.

mne/viz/_3d.py Outdated Show resolved Hide resolved
mne/utils/docs.py Outdated Show resolved Hide resolved
@larsoner larsoner modified the milestones: 1.9, 1.10 Dec 14, 2024
@drammock drammock enabled auto-merge (squash) January 9, 2025 16:46
@larsoner larsoner disabled auto-merge January 10, 2025 17:14
@larsoner larsoner merged commit 176f64f into mne-tools:main Jan 10, 2025
28 of 30 checks passed
Copy link

welcome bot commented Jan 10, 2025

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

qian-chu pushed a commit to qian-chu/mne-python that referenced this pull request Jan 20, 2025
larsoner added a commit to larsoner/mne-python that referenced this pull request Jan 24, 2025
* upstream/main: (57 commits)
  Allow lasso selection sensors in a plot_evoked_topo (mne-tools#12071)
  MAINT: Fix doc build (mne-tools#13076)
  BUG: Improve sklearn compliance (mne-tools#13065)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13073)
  MAINT: Add Numba to 3.13 test (mne-tools#13075)
  Bump autofix-ci/action from ff86a557419858bb967097bfc916833f5647fa8c to 551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef in the actions group (mne-tools#13071)
  [BUG] Correct annotation onset for exportation to EDF and EEGLAB (mne-tools#12656)
  New feature for removing heart artifacts from EEG or ESG data using a Principal Component Analysis - Optimal Basis Sets (PCA-OBS) algorithm (mne-tools#13037)
  [BUG] Fix taper weighting in computation of TFR multitaper power (mne-tools#13067)
  [FIX] Reading an EDF with preload=False and mixed frequency (mne-tools#13069)
  Fix evoked topomap colorbars, closes mne-tools#13050 (mne-tools#13063)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13060)
  BUG: Fix bug with interval calculation (mne-tools#13062)
  [DOC] extend documentation for add_channels (mne-tools#13051)
  Add `combine_tfr` to API (mne-tools#13054)
  Add `combine_spectrum()` function and allow `grand_average()` to support `Spectrum` data (mne-tools#13058)
  BUG: Fix bug with helium anon (mne-tools#13056)
  [ENH] Add option to store and return TFR taper weights (mne-tools#12910)
  BUG: viz plot window's 'title' argument showed no effect. (mne-tools#12828)
  MAINT: Ensure limited set of tests are skipped (mne-tools#13053)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants