Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support axes arg for field mode #12655

Merged
merged 5 commits into from
Jun 10, 2024
Merged

ENH: Support axes arg for field mode #12655

merged 5 commits into from
Jun 10, 2024

Conversation

larsoner
Copy link
Member

Pretty straightforward PR to add support for passing axes when calling plot_head_positions(..., mode="field").

Cleaned up tests and added a kw-only * in there while I was changing code anyway.

@larsoner larsoner added this to the 1.8 milestone Jun 10, 2024
Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nitpick on the test

mne/viz/tests/test_3d.py Outdated Show resolved Hide resolved
@larsoner larsoner enabled auto-merge (squash) June 10, 2024 19:58
@larsoner larsoner merged commit b167573 into mne-tools:main Jun 10, 2024
28 checks passed
@larsoner larsoner deleted the ax branch June 10, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants